linux-kernel - Re: [PATCH] reset: socfpga: add an early reset driver for SoCFPGA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1538753420.3545.39.camel@pengutronix.de>
Date:   Fri, 05 Oct 2018 17:30:20 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Dinh Nguyen <dinguyen@...nel.org>
Cc:     marex@...x.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] reset: socfpga: add an early reset driver for SoCFPGA

Hi Dinh,

On Fri, 2018-10-05 at 10:17 -0500, Dinh Nguyen wrote:
[...]
> > > +static int a10_reset_init(struct device_node *np)
> > > +{
> > > +	struct reset_simple_data *data;
> > > +	struct resource res;
> > > +	resource_size_t size;
> > > +	int ret;
> > > +	u32 reg_offset = 0;
> > 
> > ... now it is 0x0.
> > I think this should be
> > 
> > 	u32 reg_offset = 0x10;
> > 
> > to avoid breaking SocFPGA with ancient device trees.
[...]
> > Could we keep the SOCFPGA_NR_BANKS #define to reduce the amount of magic
> > numbers?
> > 
> > I can make both changes when applying if you want.
> > 
> 
> If you don't mind, that would be great!

Done, applied to reset/next with the above changes.


I get the following build warning:

  drivers/reset/reset-socfpga.c:81:13: warning: symbol 'socfpga_reset_init' was not declared. Should it be static?

It would be nice to put the declaration into a header in
include/soc/socfpga (or wherever is more appropriate) at some point.

regards
Philipp