linux-kernel - Re: [PATCH] usbip: vhci_hcd: check port number before using

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7da9adc-3cb3-c5a6-519c-ba4440897c28@kernel.org>
Date:   Mon, 8 Oct 2018 13:28:57 -0600
From:   Shuah Khan <shuah@...nel.org>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Valentina Manea <valentina.manea.m@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        syzbot+600b03e0cf1b73bb23c4@...kaller.appspotmail.com,
        stable <stable@...r.kernel.org>, Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] usbip: vhci_hcd: check port number before using

Hi Sudip,

On 10/08/2018 01:19 PM, Sudip Mukherjee wrote:
> From: Sudip Mukherjee <sudipm.mukherjee@...il.com>
> 
> The port number is checked and it just prints an error message but it
> still continues to use the invalid port. And as a result it accesses
> memory which is not its resulting in  BUG report from KASAN.

Yes there is an issue with out of bounds access. But this isn't the
right fix.

> 
> Reported-by: syzbot+600b03e0cf1b73bb23c4@...kaller.appspotmail.com
> Cc: stable <stable@...r.kernel.org>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@...il.com>

I sent in a fix for this last Friday.

https://patchwork.kernel.org/patch/10628833/

thanks,
-- Shuah