linux-kernel - Re: [PATCH] video: fbdev: sis: Remove unnecessary parentheses and commented code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 8 Oct 2018 12:51:54 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Thomas Winischhofer <thomas@...ischhofer.net>,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: fbdev: sis: Remove unnecessary parentheses and
 commented code


On 09/20/2018 10:22 PM, Nathan Chancellor wrote:
> Clang warns when multiple pairs of parentheses are used for a single
> conditional statement.
> 
> drivers/video/fbdev/sis/init301.c:851:42: warning: equality comparison
> with extraneous parentheses [-Wparentheses-equality]
>       } else if((SiS_Pr->SiS_IF_DEF_LVDS == 1) /* ||
>                  ~~~~~~~~~~~~~~~~~~~~~~~~^~~~
> drivers/video/fbdev/sis/init301.c:851:42: note: remove extraneous
> parentheses around the comparison to silence this warning
>       } else if((SiS_Pr->SiS_IF_DEF_LVDS == 1) /* ||
>                 ~                        ^   ~
> drivers/video/fbdev/sis/init301.c:851:42: note: use '=' to turn this
> equality comparison into an assignment
>       } else if((SiS_Pr->SiS_IF_DEF_LVDS == 1) /* ||
>                                          ^~
>                                          =
> 1 warning generated.
> 
> Remove the parentheses and while we're at it, clean up the commented
> code, which has been here since the beginning of git history.
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/118
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Patch queued for 4.20, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics