linux-kernel - Re: [PATCH] fbdev: fix broken menu dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 8 Oct 2018 12:52:30 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
        Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Alexander Shiyan <shc_work@...l.ru>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] fbdev: fix broken menu dependencies


On 09/23/2018 12:43 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> The framebuffer options and devices menu is unintentionally split
> or broken because some items in it do not depend on FB (including
> several under omap and mmp).
> Fix this by moving FB_CMDLINE, FB_NOTIFY, and FB_CLPS711X_OLD to
> just before the FB Kconfig symbol definition and by moving the
> omap, omap2, and mmp menus to last, following FB_SM712.
> 
> Also, the FB_VIA dependencies are duplicated by both being inside
> an "if FB_VIA/endif" block and "depends on FB_VIA", so drop the
> "depends on FB_VIA" lines since they are redundant.
> 
> Fixes: ea6763c104c9 ("video/fbdev: Always built-in video= cmdline parsing")
> Fixes: 5ec9653806ba ("fbdev: Make fb-notify a no-op if CONFIG_FB=n")
> Fixes: ef74d46a4ef3 ("video: clps711x: Add new Cirrus Logic CLPS711X framebuffer driver")
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
> Cc: Daniel Vetter <daniel.vetter@...ll.ch>
> Cc: Alexander Shiyan <shc_work@...l.ru>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: linux-fbdev@...r.kernel.org

Patch queued for 4.20, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics