linux-kernel - Re: [PATCH RFC] proc: Don't retain negative dentries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181008165545.GE32577@ZenIV.linux.org.uk>
Date:   Mon, 8 Oct 2018 17:55:45 +0100
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Alexey Dobriyan <adobriyan@...il.com>,
        David Howells <dhowells@...hat.com>,
        Florian Westphal <fw@...len.de>, linux-kernel@...r.kernel.org,
        kernel@...gutronix.de
Subject: Re: [PATCH RFC] proc: Don't retain negative dentries

On Mon, Oct 08, 2018 at 06:50:10PM +0200, Ahmad Fatoum wrote:
> The referenced commit 1da4d377f94 ("proc: revalidate misc dentries")
> caused following userspace code to access a stale /proc/net/dev
> after the network namespace was changed:

> Despite switching the network namespace, the read access from the
> newly opened file gave back what the very first read in the default
> network namespace returned.

What the hell does that have to do with negative dentries anywhere???

NAK.  Rationale makes no sense _and_ the patch has nothing to do
with claimed rationale.