linux-kernel - [PATCH net-next] rtnetlink: mpls: ip_valid_fib_dump_req() requires CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181009161031.1003047-1-arnd@arndb.de>
Date:   Tue,  9 Oct 2018 18:10:00 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     "David S. Miller" <davem@...emloft.net>,
        David Ahern <dsahern@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>, Kirill Tkhai <ktkhai@...tuozzo.com>,
        Christian Brauner <christian@...uner.io>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH net-next] rtnetlink: mpls: ip_valid_fib_dump_req() requires CONFIG_INET

The newly added call to ip_valid_fib_dump_req() causes a link error
in configurations that enable MPLS but not IPv4:

net/mpls/af_mpls.o: In function `mpls_dump_routes':
af_mpls.c:(.text+0xed0): undefined reference to `ip_valid_fib_dump_req'

With the added IS_ENABLED() check we get the previous behavior
back in that configuration, and skip the check.

Fixes: e8ba330ac0c5 ("rtnetlink: Update fib dumps for strict data checking")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 net/mpls/af_mpls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index 7f891ffffc05..99ff6114d513 100644
--- a/net/mpls/af_mpls.c
+++ b/net/mpls/af_mpls.c
@@ -2041,7 +2041,7 @@ static int mpls_dump_routes(struct sk_buff *skb, struct netlink_callback *cb)
 
 	ASSERT_RTNL();
 
-	if (cb->strict_check) {
+	if (IS_ENABLED(CONFIG_INET) && cb->strict_check) {
 		int err = ip_valid_fib_dump_req(nlh, cb->extack);
 
 		if (err < 0)
-- 
2.18.0