linux-kernel - Re: [PATCH] fs/ocfs2/dlmglue: lockdep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181009182217.GA18663@zn.tnic>
Date:   Tue, 9 Oct 2018 20:22:17 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Anders Roxell <anders.roxell@...aro.org>
Cc:     geert@...ux-m68k.org, Mark Fasheh <mark@...heh.com>,
        Joel Becker <jlbec@...lplan.org>, ocfs2-devel@....oracle.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] fs/ocfs2/dlmglue: lockdep_keys defined but not used

On Fri, Aug 24, 2018 at 03:07:03PM +0200, Anders Roxell wrote:
> On Thu, 23 Aug 2018 at 23:07, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> >
> > Hi Anders,
> >
> > On Wed, Jul 4, 2018 at 11:54 AM Anders Roxell <anders.roxell@...aro.org> wrote:
> > > When CONFIG_DEBUG_LOCK_ALLOC isn't enabled lockdep_keys isn't used and
> > > we get a warning:
> > > fs/ocfs2/dlmglue.c:99:30: warning: ‘lockdep_keys’ defined but not used
> > >     [-Wunused-variable]
> > >  static struct lock_class_key lockdep_keys[OCFS2_NUM_LOCK_TYPES];
> > >                               ^~~~~~~~~~~~
> > > Adding __maybe_unused to the declaration hids the warning.
> >
> > Thanks for your patcj!
> >
> > > Fixes: 1cd75cdb8fbb ("ocfs2: make several functions and variables static (and some const)")
> >
> > Fixes: 480bd56485b77c36 ("ocfs2: make several functions and variables
> > static (and some const)")
> 
> Thanks, thats correct.
> 
> >
> > Presumably the branch got rebased?
> 
> probably.
> 
> Mark, Joel, do you want me to send a new patch where I correct the sha
> in the "Fixes" part of the changelog or can you fix that?

FWIW, I'm still seeing this in randconfig builds here.

Adding akpm in case no one picks this up.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.