[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <875zy85nd9.fsf@mail.parknet.co.jp>
Date: Fri, 12 Oct 2018 03:50:26 +0900
From: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org,
Khazhismel Kumykov <khazhy@...gle.com>
Subject: Re: [PATCH] fs/fat: add cond_resched to fat_count_free_clusters
Khazhismel Kumykov <khazhy@...gle.com> writes:
> On non-preempt kernels this loop can take a long time (more than 50
> ticks) processing through entries.
>
> Signed-off-by: Khazhismel Kumykov <khazhy@...gle.com>
> ---
> fs/fat/fatent.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/fat/fatent.c b/fs/fat/fatent.c
> index defc2168de91..f58c0cacc531 100644
> --- a/fs/fat/fatent.c
> +++ b/fs/fat/fatent.c
> @@ -682,6 +682,7 @@ int fat_count_free_clusters(struct super_block *sb)
> if (ops->ent_get(&fatent) == FAT_ENT_FREE)
> free++;
> } while (fat_ent_next(sbi, &fatent));
> + cond_resched();
> }
> sbi->free_clusters = free;
> sbi->free_clus_valid = 1;
Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Thanks, looks good.
--
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Powered by blists - more mailing lists