[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <CDC45F66-4637-4038-ACB7-43DAA9E6A3B6@holtmann.org>
Date: Sun, 14 Oct 2018 10:33:34 +0200
From: Marcel Holtmann <marcel@...tmann.org>
To: Colin King <colin.king@...onical.com>
Cc: Johan Hedberg <johan.hedberg@...il.com>,
"David S. Miller" <davem@...emloft.net>,
linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: Remove redundant check on status
Hi Colin,
> The check on statis is redundant as a status has to be zero at
> the point it is being checked because of a previous check and return
> path via label 'unlock'. Remove the redundant check and the deadcode
> that can never be reached.
>
> Detected by CoverityScan, CID#1471710 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
> net/bluetooth/hci_event.c | 38 +++++++++++++++++---------------------
> 1 file changed, 17 insertions(+), 21 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
Powered by blists - more mailing lists