| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <886d0f79d59d2d35ca75f9d2d79cdb45c1628c78.camel@suse.com>
Date: Mon, 15 Oct 2018 10:55:54 +0200
From: Vasilis Liaskovitis <vliaskovitis@...e.com>
To: Roger Pau Monné <roger.pau@...rix.com>
Cc: axboe@...nel.dk, jgross@...e.com, konrad.wilk@...cle.com,
linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
xen-devel@...ts.xenproject.org, boris.ostrovsky@...cle.com
Subject: Re: [Xen-devel] [PATCH] xen/blkfront: avoid NULL blkfront_info
dereference on device removal
On Thu, 2018-10-11 at 18:34 +0200, Roger Pau Monné wrote:
> --- a/drivers/block/xen-blkfront.c
> > +++ b/drivers/block/xen-blkfront.c
> > @@ -2493,6 +2493,9 @@ static int blkfront_remove(struct
> > xenbus_device *xbdev)
> >
> > dev_dbg(&xbdev->dev, "%s removed", xbdev->nodename);
> >
> > + if (!info)
> > + goto out;
>
> I don't see the point in adding the 'out' label. Can you just return
> 0
> here?
of course, I will send a second version.
thanks for the review,
- Vasilis
>
> Thanks, Roger.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...ts.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel
Powered by blists - more mailing lists