[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181015085737.GC27159@lst.de>
Date: Mon, 15 Oct 2018 10:57:37 +0200
From: Christoph Hellwig <hch@....de>
To: Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc: Christoph Hellwig <hch@....de>, mporter@...nel.crashing.org,
alex.bou9@...il.com,
Dominik Brodowski <linux@...inikbrodowski.net>,
Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
linux-pci@...r.kernel.org, linux-scsi <linux-scsi@...r.kernel.org>,
linux-arch <linux-arch@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH 4/8] pci: consolidate PCI config entry in drivers/pci
On Mon, Oct 15, 2018 at 03:37:05PM +0900, Masahiro Yamada wrote:
> I think HAVE_ is a preferred prefix in this case according to this doc:
> https://github.com/masahir0y/linux/blob/v4.19-rc4/Documentation/kbuild/kconfig-language.txt#L448
Ok, I'll switch everything to HAVE_*
> If you do this for entire powerpc,
> the other 'select HAS_PCI' addtions to
> arch/powerpc/platforms/*/Kconfig look redundant.
I'll drop them.
> > -config PCI
> > - bool "PCI support"
> > - select PCI_MSI
>
>
> I think this 'select PCI_MSI' for riscv was lost.
Indeed, fixed.
> > menu "Bus options (PCI etc.)"
> >
> > -config PCI
> > - bool "PCI support"
> > - default y
>
>
> The default is y for x86 (and xtensa as well).
>
> With this patch, the default will be flipped.
>
> I think most of people want to use PCI for x86,
> and this change will make people upset.
>
> Will you update arch/{x86,xtensa}/configs/*_defconfig?
Yes. Alternatively we could add a new ARCH_PCI_DEFAULT symbol,
that architectures could select if they want PCI by default. Does
anyone thing this is a good idea?
Powered by blists - more mailing lists