linux-kernel - Re: [PATCH 7/8] media: sti/bdisp: don't pass GFP_DMA32 to dma_alloc_attrs

Open Source and information security mailing list archives

Message-ID: <CA+M3ks5KO-Yr_PEczaENhTfirthFz2gW1uv4bwZe5mjy3-jZyg@mail.gmail.com>
Date:   Mon, 15 Oct 2018 11:12:55 +0200
From:   Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:     Christoph Hellwig <hch@....de>
Cc:     linux-pm@...r.kernel.org, linux-tegra@...r.kernel.org,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        linux-media@...r.kernel.org, linux-spi@...r.kernel.org,
        Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
        alsa-devel@...a-project.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 7/8] media: sti/bdisp: don't pass GFP_DMA32 to dma_alloc_attrs

Le sam. 13 oct. 2018 à 17:18, Christoph Hellwig <hch@....de> a écrit :
>
> The DMA API does its own zone decisions based on the coherent_dma_mask.
>
> Signed-off-by: Christoph Hellwig <hch@....de>

Reviewed-by: Benjamin Gaignard <benjamin.gaignard@...aro.org>

> ---
>  drivers/media/platform/sti/bdisp/bdisp-hw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/sti/bdisp/bdisp-hw.c b/drivers/media/platform/sti/bdisp/bdisp-hw.c
> index 26d9fa7aeb5f..4372abbb5950 100644
> --- a/drivers/media/platform/sti/bdisp/bdisp-hw.c
> +++ b/drivers/media/platform/sti/bdisp/bdisp-hw.c
> @@ -510,7 +510,7 @@ int bdisp_hw_alloc_filters(struct device *dev)
>
>         /* Allocate all the filters within a single memory page */
>         size = (BDISP_HF_NB * NB_H_FILTER) + (BDISP_VF_NB * NB_V_FILTER);
> -       base = dma_alloc_attrs(dev, size, &paddr, GFP_KERNEL | GFP_DMA,
> +       base = dma_alloc_attrs(dev, size, &paddr, GFP_KERNEL,
>                                DMA_ATTR_WRITE_COMBINE);
>         if (!base)
>                 return -ENOMEM;
> --
> 2.19.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel


-- 
Benjamin Gaignard

Graphic Study Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives