linux-kernel - Re: [PATCH 6/8] drm: sti: don't pass GFP_DMA32 to dma_alloc_wc

Open Source and information security mailing list archives

Message-ID: <CA+M3ks6a-D4j425JGBof+ma3NX5Fo52k5fadRNRauexOBXuaaw@mail.gmail.com>
Date:   Tue, 16 Oct 2018 14:41:23 +0200
From:   Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:     Christoph Hellwig <hch@....de>
Cc:     linux-pm@...r.kernel.org, linux-tegra@...r.kernel.org,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        linux-media@...r.kernel.org, linux-spi@...r.kernel.org,
        Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
        alsa-devel@...a-project.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/8] drm: sti: don't pass GFP_DMA32 to dma_alloc_wc

Le lun. 15 oct. 2018 à 11:12, Benjamin Gaignard
<benjamin.gaignard@...aro.org> a écrit :
>
> Le sam. 13 oct. 2018 à 17:17, Christoph Hellwig <hch@....de> a écrit :
> >
> > The DMA API does its own zone decisions based on the coherent_dma_mask.
> >
> > Signed-off-by: Christoph Hellwig <hch@....de>
>
> Reviewed-by: Benjamin Gaignard <benjamin.gaignard@...aro.org>

Christoph do you plan to merge this patch on your own tree ? or would
like I put it directly in drm-misc-next branch ?

Regards,
Benjamin
>
> > ---
> >  drivers/gpu/drm/sti/sti_gdp.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c
> > index c32de6cbf061..cdf0a1396e00 100644
> > --- a/drivers/gpu/drm/sti/sti_gdp.c
> > +++ b/drivers/gpu/drm/sti/sti_gdp.c
> > @@ -517,7 +517,7 @@ static void sti_gdp_init(struct sti_gdp *gdp)
> >         /* Allocate all the nodes within a single memory page */
> >         size = sizeof(struct sti_gdp_node) *
> >             GDP_NODE_PER_FIELD * GDP_NODE_NB_BANK;
> > -       base = dma_alloc_wc(gdp->dev, size, &dma_addr, GFP_KERNEL | GFP_DMA);
> > +       base = dma_alloc_wc(gdp->dev, size, &dma_addr, GFP_KERNEL);
> >
> >         if (!base) {
> >                 DRM_ERROR("Failed to allocate memory for GDP node\n");
> > --
> > 2.19.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@...ts.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
>
> --
> Benjamin Gaignard
>
> Graphic Study Group
>
> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: Facebook | Twitter | Blog

-- 
Benjamin Gaignard

Graphic Study Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives