linux-kernel - Re: Can we just remove the sw_lpm_support from current xhci driver?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <155e2a10-d324-6bc6-b3fc-b23d15a3af25@intel.com>
Date:   Mon, 15 Oct 2018 15:11:19 +0300
From:   Mathias Nyman <mathias.nyman@...el.com>
To:     "Zengtao (B)" <prime.zeng@...ilicon.com>,
        Greg KH <gregkh@...uxfoundation.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: Re: Can we just remove the sw_lpm_support from current xhci driver?

On 15.10.2018 12:35, Zengtao (B) wrote:
> Hi:
> 
> I am recently reading the LPM related code in xhci driver, and I find
> that the xhci->sw_lpm_support is not really used, but I am not sure
>   whether we should remove it or not?
> 
> Any ideas, Thanks.

I think it was used to prevent LPM in pre-0.96 xHC controllers.
Now driver only supports HW LPM for 1.0 and later controllers, so xhci->sw_lpm_support
doesn't really do anything.

You can send a patch removing it

Thanks
-Mathias