linux-kernel - RE: Can we just remove the sw_lpm_support from current xhci driver?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <678F3D1BB717D949B966B68EAEB446ED1F18ECDC@dggemm526-mbx.china.huawei.com>
Date:   Tue, 16 Oct 2018 03:23:05 +0000
From:   "Zengtao (B)" <prime.zeng@...ilicon.com>
To:     Mathias Nyman <mathias.nyman@...el.com>,
        Greg KH <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: RE: Can we just remove the sw_lpm_support from current xhci driver?

Hi Mathias:

>-----Original Message-----
>From: Mathias Nyman [mailto:mathias.nyman@...el.com]
>Sent: Monday, October 15, 2018 8:11 PM
>To: Zengtao (B) <prime.zeng@...ilicon.com>; Greg KH
><gregkh@...uxfoundation.org>
>Cc: linux-kernel@...r.kernel.org; linux-usb@...r.kernel.org
>Subject: Re: Can we just remove the sw_lpm_support from current xhci
>driver?
>
>On 15.10.2018 12:35, Zengtao (B) wrote:
>> Hi:
>>
>> I am recently reading the LPM related code in xhci driver, and I find
>> that the xhci->sw_lpm_support is not really used, but I am not sure
>>   whether we should remove it or not?
>>
>> Any ideas, Thanks.
>
>I think it was used to prevent LPM in pre-0.96 xHC controllers.
>Now driver only supports HW LPM for 1.0 and later controllers, so
>xhci->sw_lpm_support doesn't really do anything.
>
>You can send a patch removing it
>
Ok, I will send a patch to do it, thanks.

>Thanks
>-Mathias