linux-kernel - RE: [PATCH v4 5/6] arm64: dts: add QorIQ LX2160A SoC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <153962211360.5275.18031876744546062419@swboyd.mtv.corp.google.com>
Date:   Mon, 15 Oct 2018 09:48:33 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Shawn Guo <shawnguo@...nel.org>,
        Vabhav Sharma <vabhav.sharma@....com>
Cc:     "sudeep.holla@....com" <sudeep.holla@....com>,
        "oss@...error.net" <oss@...error.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "rjw@...ysocki.net" <rjw@...ysocki.net>,
        "viresh.kumar@...aro.org" <viresh.kumar@...aro.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel-owner@...r.kernel.org" 
        <linux-kernel-owner@...r.kernel.org>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will.deacon@....com" <will.deacon@....com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "kstewart@...uxfoundation.org" <kstewart@...uxfoundation.org>,
        "yamada.masahiro@...ionext.com" <yamada.masahiro@...ionext.com>,
        Leo Li <leoyang.li@....com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        Varun Sethi <V.Sethi@....com>, Udit Kumar <udit.kumar@....com>,
        Pankaj Bansal <pankaj.bansal@....com>,
        Ramneek Mehresh <ramneek.mehresh@....com>,
        Ying Zhang <ying.zhang22455@....com>,
        Nipun Gupta <nipun.gupta@....com>,
        Priyanka Jain <priyanka.jain@....com>,
        Yogesh Narayan Gaur <yogeshnarayan.gaur@....com>,
        Sriram Dash <sriram.dash@....com>
Subject: RE: [PATCH v4 5/6] arm64: dts: add QorIQ LX2160A SoC support

Quoting Vabhav Sharma (2018-10-14 19:58:15)
> > > +
> > > +   pmu {
> > > +           compatible = "arm,cortex-a72-pmu";
> > > +           interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
> > > +   };
> > > +
> > > +   psci {
> > > +           compatible = "arm,psci-0.2";
> > > +           method = "smc";
> > > +   };
> > > +
> > > +   memory@...00000 {
> > > +           // DRAM space - 1, size : 2 GB DRAM
> > > +           device_type = "memory";
> > > +           reg = <0x00000000 0x80000000 0 0x80000000>;
> > > +   };
> > > +
> > > +   ddr1: memory-controller@...0000 {
> > > +           compatible = "fsl,qoriq-memory-controller";
> > > +           reg = <0x0 0x1080000 0x0 0x1000>;
> > > +           interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
> > > +           little-endian;
> > > +   };
> > > +
> > > +   ddr2: memory-controller@...0000 {
> > > +           compatible = "fsl,qoriq-memory-controller";
> > > +           reg = <0x0 0x1090000 0x0 0x1000>;
> > > +           interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
> > > +           little-endian;
> > > +   };
> > > +
> > > +   sysclk: sysclk {
> > 
> > Name the node a bit generic like clock-xxx.
> There is only one clock-unit, Bootloader(U-boot) require sysclk node during device tree fix-up as different platform support varied platform frequency as per reset configuration word used.
> Referred other ARM based platform with one clock using name as x: x

Please add a comment above this node with this information. Newcomers
reading this DTS file won't have any idea why this node is specially
named and a comment will help tremendously here.