linux-kernel - Re: [PATCH 1/2] sysfs: constify sysfs create/remove files harder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181016124745.GA7733@kroah.com>
Date:   Tue, 16 Oct 2018 14:47:45 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Jani Nikula <jani.nikula@...el.com>
Cc:     linux-kernel@...r.kernel.org, intel-gfx@...ts.freedesktop.org,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH 1/2] sysfs: constify sysfs create/remove files harder

On Tue, Oct 16, 2018 at 03:10:24PM +0300, Jani Nikula wrote:
> On Tue, 16 Oct 2018, Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> > On Tue, Oct 16, 2018 at 02:38:53PM +0300, Jani Nikula wrote:
> >> On Tue, 16 Oct 2018, Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> >> > On Thu, Oct 04, 2018 at 05:37:49PM +0300, Jani Nikula wrote:
> >> >> Let the passed in array be const (and thus placed in rodata) instead of
> >> >> a mutable array of const pointers.
> >> >> 
> >> >> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> >> >> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> >> >> Signed-off-by: Jani Nikula <jani.nikula@...el.com>
> >> >> ---
> >> >>  fs/sysfs/file.c       | 4 ++--
> >> >>  include/linux/sysfs.h | 8 ++++----
> >> >>  2 files changed, 6 insertions(+), 6 deletions(-)
> >> >
> >> > Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> >> 
> >> Thanks; who should pick them up?
> >
> > I could pick the first one up, but as you need this for a drm patch,
> > both should probably go through that tree, right?
> 
> I can pick them both if it doesn't bother you that the sysfs parts will
> be merged in the merge window for v4.21 i.e. the change would be in drm
> trees for an entire release cycle. We've been done for v4.20 merge
> window for a while now.

No objection from me.

greg k-h