linux-kernel - Re: [PATCH -next] advansys: use correct srb_tag in adv_isr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <82ba2304-8dd8-5da6-29f3-40e5c878815a@huawei.com>
Date:   Wed, 17 Oct 2018 20:03:41 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     <matthew@....cx>, <hare@...e.com>, <jejb@...ux.vnet.ibm.com>,
        <linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH -next] advansys: use correct srb_tag in adv_isr_callback


On 2018/10/17 9:34, Martin K. Petersen wrote:
> 
> Hi Yue Haibing,
> 
>>  	srb_tag = le32_to_cpu(scsiqp->srb_tag);
>> -	scp = scsi_host_find_tag(boardp->shost, scsiqp->srb_tag);
>> +	scp = scsi_host_find_tag(boardp->shost, srb_tag);
> 
> Maybe I'm missing something, but I don't see where in the code
> scsiqp->srb_tag is being converted to le32. srb_tag is beyond the memory
> accessed by the controller and thus wouldn't need to be little endian.

Thanks for comment this.

So 'srb_tag' can been removed.

>