linux-kernel - Re: [PATCH -next] advansys: use correct srb_tag in adv_isr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1murdpd9z.fsf@oracle.com>
Date:   Tue, 16 Oct 2018 21:34:00 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     <matthew@....cx>, <hare@...e.com>, <jejb@...ux.vnet.ibm.com>,
        <martin.petersen@...cle.com>, <linux-kernel@...r.kernel.org>,
        <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH -next] advansys: use correct srb_tag in adv_isr_callback


Hi Yue Haibing,

>  	srb_tag = le32_to_cpu(scsiqp->srb_tag);
> -	scp = scsi_host_find_tag(boardp->shost, scsiqp->srb_tag);
> +	scp = scsi_host_find_tag(boardp->shost, srb_tag);

Maybe I'm missing something, but I don't see where in the code
scsiqp->srb_tag is being converted to le32. srb_tag is beyond the memory
accessed by the controller and thus wouldn't need to be little endian.

-- 
Martin K. Petersen	Oracle Linux Engineering