linux-kernel - RE: [PATCH] xhci: remove the unused sw_lpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 17 Oct 2018 02:05:25 +0000
From:   "Zengtao (B)" <prime.zeng@...ilicon.com>
To:     Mathias Nyman <mathias.nyman@...ux.intel.com>,
        "mathias.nyman@...el.com" <mathias.nyman@...el.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] xhci: remove the unused sw_lpm_support

Hi  Mathias:

>-----Original Message-----
>From: Mathias Nyman [mailto:mathias.nyman@...ux.intel.com]
>Sent: Tuesday, October 16, 2018 8:34 PM
>To: Zengtao (B) <prime.zeng@...ilicon.com>; mathias.nyman@...el.com;
>gregkh@...uxfoundation.org
>Cc: linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org
>Subject: Re: [PATCH] xhci: remove the unused sw_lpm_support
>
>On 16.10.2018 14:37, Zeng Tao wrote:
>> It is introduced for the pre-0.96 xHC controllers, and the driver only
>> support HW LPM for 1.0 and later controllers.It's not actually used
>> now and is thought not to be used in the future any more, so just
>remove it.
>>
>> Acked-by: Mathias Nyman <mathias.nyman@...el.com>
>
>Please don't add my Acked-by to patches I haven't seen.
>
> From Documentation/process/submitting-patches.rst:
>
Thanks for pointing out the wrong tag, I meant to add suggested-by, ^_^

>"Acked-by: is not as formal as Signed-off-by:.  It is a record that the acker
>has at least reviewed the patch and has indicated acceptance."
>
>> Signed-off-by: Zeng Tao <prime.zeng@...ilicon.com>
>
>Otherwise the patch looks good, I'll queue it, and remove the extra
>Acked-by
>
It's ok for me,  thank you.

Regards
Zengtao