linux-kernel - Re: [PATCH 2/4] fscache: Fix race in fscache_op_complete() due to split atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14408.1539790333@warthog.procyon.org.uk>
Date:   Wed, 17 Oct 2018 16:32:13 +0100
From:   David Howells <dhowells@...hat.com>
To:     Andrea Parri <andrea.parri@...rulasolutions.com>
Cc:     dhowells@...hat.com, gregkh@...ux-foundation.org,
        Kiran Kumar Modukuri <kiran.modukuri@...il.com>,
        viro@...iv.linux.org.uk, sandeen@...hat.com,
        linux-cachefs@...hat.com, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] fscache: Fix race in fscache_op_complete() due to split atomic_sub & read

Andrea Parri <andrea.parri@...rulasolutions.com> wrote:

> > Fix this by using atomic_sub_return() instead of two calls.
> 
> Seems a case for atomic_sub_return_relaxed()... why not?

Ummm...  In that case, should it be atomic_sub_return_release()?

David