linux-kernel - Re: [PATCH 2/2] phy: ocelot-serdes: fix out-of-bounds read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d4347a46-ff54-3b02-97b7-58ad7017c2c0@embeddedor.com>
Date:   Wed, 17 Oct 2018 17:37:47 +0200
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Kishon Vijay Abraham I <kishon@...com>,
        Quentin Schulz <quentin.schulz@...tlin.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] phy: ocelot-serdes: fix out-of-bounds read

Hi Kishon,

On 10/16/18 10:48 AM, Kishon Vijay Abraham I wrote:
> Hi,
> 
> On Tuesday 16 October 2018 02:16 PM, Gustavo A. R. Silva wrote:
>> Hi,
>>
>> On 10/9/18 9:28 AM, Quentin Schulz wrote:
>>> Hi Gustavo,
>>>
>>> On Tue, Oct 09, 2018 at 12:22:33AM +0200, Gustavo A. R. Silva wrote:
>>>> Currently, there is an out-of-bounds read on array ctrl->phys,
>>>> once variable i reaches the maximum array size of SERDES_MAX
>>>> in the for loop.
>>>>
>>>> Fix this by changing the condition in the for loop from
>>>> i <= SERDES_MAX to i < SERDES_MAX.
>>>>
>>>
>>> Reviewed-by: Quentin Schulz <quentin.schulz@...tlin.com>
>>>
>>
>> Friendly ping. Who can you take this?
> 
> This can go during the 4.20 -rc cycle.
> 

Should I resend the following patch to you, so the whole series is
applied to your phy tree?

https://lore.kernel.org/patchwork/patch/997326/

Thanks
--
Gustavo