linux-kernel - Re: [PATCH 1/3] nfc: pn533: add UART phy driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181018130346.GA3975@lem-wkst-02.lemonage>
Date:   Thu, 18 Oct 2018 15:03:46 +0200
From:   Lars Poeschel <poeschel@...onage.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Samuel Ortiz <sameo@...ux.intel.com>, Jiri Slaby <jslaby@...e.com>,
        Kees Cook <keescook@...omium.org>,
        linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH 1/3] nfc: pn533: add UART phy driver

On Wed, Oct 17, 2018 at 01:53:57PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Oct 17, 2018 at 12:20:35PM +0200, Lars Poeschel wrote:
> > This adds the UART phy interface for the pn533 driver.
> > The pn533 driver can be used through UART interface this way.
> > It is implemented as a tty line discipline.
> 
> Why not use the serdev interface instead?

Maybe because the most obivious is not obivious enough. ;)
I did not know about serdev before. Thank you very much for this! I am
almost finished migrating to serdev and everything is much cleaner and
more simple now!

I will post a follow-up with all your other comments addressed.

Thanks,
Lars