linux-kernel - Re: [PATCH] cacheinfo: Keep the old value if of_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181019091859.GA17312@e107155-lin>
Date:   Fri, 19 Oct 2018 10:18:59 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     陈华才 <chenhc@...ote.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        zhangfx <zhangfx@...ote.com>, wuzhangjin <wuzhangjin@...il.com>,
        Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH] cacheinfo: Keep the old value if
 of_property_read_u32fails

Hi,

On Fri, Oct 19, 2018 at 02:23:27PM +0800, 陈华才 wrote:
> Hi, Sudeep,
>
> I use MIPS, and there is no "size" in
> /sys/devices/system/cpu/cpuX/cache/indexX/ file after your patch. Because
> the DT node only has "next-level-cache = <&L2>;"  but has no "size"
> information.
>
Thanks for the confirmation and your time. I was worried if this was ARM64
with local patches.

You can add:
Reviewed-by: Sudeep Holla <sudeep.holla@....com>

Also please add:
Fixes: 448a5a552f33 ("drivers: base: cacheinfo: use OF property_read_u32 instead of get_property,read_number")

--
Regards,
Sudeep