linux-kernel - Re: [PATCH 02/24] iov_iter: Renumber the ITER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 20 Oct 2018 05:59:33 +0100
From:   Al Viro <viro@...IV.linux.org.uk>
To:     David Howells <dhowells@...hat.com>
Cc:     linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/24] iov_iter: Renumber the ITER_* constants in uio.h

On Sat, Oct 20, 2018 at 02:10:52AM +0100, David Howells wrote:
> Renumber the ITER_* constants in uio.h to be contiguous to make comparing
> them more efficient in a switch-statement.

Are you sure that they *are* more efficient that way?  Some of those paths
are fairly hot, so much that I would really like to see profiles before
and after these changes (both this and the previous one).