linux-kernel - Re: [PATCH 03/24] iov_iter: Add I/O discard iterator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181020050521.GJ32577@ZenIV.linux.org.uk>
Date:   Sat, 20 Oct 2018 06:05:22 +0100
From:   Al Viro <viro@...IV.linux.org.uk>
To:     David Howells <dhowells@...hat.com>
Cc:     linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/24] iov_iter: Add I/O discard iterator

On Sat, Oct 20, 2018 at 02:10:59AM +0100, David Howells wrote:

> @@ -1060,6 +1074,9 @@ void iov_iter_revert(struct iov_iter *i, size_t unroll)
>  	}
>  	unroll -= i->iov_offset;
>  	switch (iov_iter_type(i)) {
> +	case ITER_DISCARD:
> +		i->iov_offset = 0;
> +		return;

... the hell?  That makes no sense whatsoever; what, besides this and immediately
preceding part of iov_iter_revert() so much as looks at ->iov_offset for those?
Just have it bugger off before the
        if (unroll <= i->iov_offset) {
                i->iov_offset -= unroll;
                return;
        }
bit...