linux-kernel - Re: [PATCH 2/5] nds32: Fix bug in bitfield.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181022101925.GB24110@andestech.com>
Date:   Mon, 22 Oct 2018 18:19:25 +0800
From:   Nick Hu <nickhu@...estech.com>
To:     Mark Rutland <mark.rutland@....com>
CC:     Greentime Ying-Han Hu(胡英漢) 
        <greentime@...estech.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "deanbo422@...il.com" <deanbo422@...il.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "acme@...nel.org" <acme@...nel.org>,
        "alexander.shishkin@...ux.intel.com" 
        <alexander.shishkin@...ux.intel.com>,
        "jolsa@...hat.com" <jolsa@...hat.com>,
        "namhyung@...nel.org" <namhyung@...nel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "sboyd@...eaurora.org" <sboyd@...eaurora.org>,
        "geert@...ux-m68k.org" <geert@...ux-m68k.org>,
        Zong Zong-Xian Li(李宗憲) 
        <zong@...estech.com>,
        "ebiederm@...ssion.com" <ebiederm@...ssion.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "pombredanne@...b.com" <pombredanne@...b.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "kstewart@...uxfoundation.org" <kstewart@...uxfoundation.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "green.hu@...il.com" <green.hu@...il.com>
Subject: Re: [PATCH 2/5] nds32: Fix bug in bitfield.h

Hi Mark,

On Thu, Oct 18, 2018 at 10:26:31PM +0800, Mark Rutland wrote:
> On Thu, Oct 18, 2018 at 04:43:14PM +0800, Nickhu wrote:
> > There two bitfield bug for perfomance counter
> > in bitfield.h:
> > 
> > 	PFM_CTL_offSEL1		21 --> 16
> > 	PFM_CTL_offSEL2		27 --> 22
> > 
> > This commit fix it.
> > 
> > Signed-off-by: Nickhu <nickhu@...estech.com>
> 
> This patch should probably be move before the patch adding perf support.
> That way, perf support isn't broken at the point it is added.
> 
> Thanks,
> Mark.
> 
> > ---
> >  arch/nds32/include/asm/bitfield.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/nds32/include/asm/bitfield.h b/arch/nds32/include/asm/bitfield.h
> > index 8e84fc385b94..19b2841219ad 100644
> > --- a/arch/nds32/include/asm/bitfield.h
> > +++ b/arch/nds32/include/asm/bitfield.h
> > @@ -692,8 +692,8 @@
> >  #define PFM_CTL_offKU1		13	/* Enable user mode event counting for PFMC1 */
> >  #define PFM_CTL_offKU2		14	/* Enable user mode event counting for PFMC2 */
> >  #define PFM_CTL_offSEL0		15	/* The event selection for PFMC0 */
> > -#define PFM_CTL_offSEL1		21	/* The event selection for PFMC1 */
> > -#define PFM_CTL_offSEL2		27	/* The event selection for PFMC2 */
> > +#define PFM_CTL_offSEL1		16	/* The event selection for PFMC1 */
> > +#define PFM_CTL_offSEL2		22	/* The event selection for PFMC2 */
> >  /* bit 28:31 reserved */
> >  
> >  #define PFM_CTL_mskEN0		( 0x01  << PFM_CTL_offEN0 )
> > -- 
> > 2.17.0
> >

Thank you for the advice !!
I will prepare another patch for it.