linux-kernel - Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Oct 2018 12:46:27 +0200
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     Yogesh Narayan Gaur <yogeshnarayan.gaur@....com>
Cc:     Tudor Ambarus <tudor.ambarus@...rochip.com>,
        "richard@....at" <richard@....at>, Mark Brown <broonie@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "nicolas.ferre@...rochip.com" <nicolas.ferre@...rochip.com>,
        "marek.vasut@...il.com" <marek.vasut@...il.com>,
        "cyrille.pitchen@...rochip.com" <cyrille.pitchen@...rochip.com>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "Cristian.Birsan@...rochip.com" <Cristian.Birsan@...rochip.com>,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        "computersforpeace@...il.com" <computersforpeace@...il.com>,
        "dwmw2@...radead.org" <dwmw2@...radead.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP
 SPI NOR flash memories

On Mon, 22 Oct 2018 10:39:48 +0000
Yogesh Narayan Gaur <yogeshnarayan.gaur@....com> wrote:

> 
> [    1.632190] Start [addr_width:00000000, read_dumy:08, read_opcode:00000000]                                                   
> [    1.639148] spi_nor_get_map_in_use:2882 smpt[0]=08ff65fc                                                                      
> [    1.644451] spi_nor_get_map_in_use:2882 smpt[1]=00000004                                                                      
> [    1.649755] spi_nor_get_map_in_use:2882 smpt[2]=04ff65fc                                                                      
> [    1.655057] spi_nor_get_map_in_use:2882 smpt[3]=00000002                                                                      
> [    1.660360] spi_nor_get_map_in_use:2882 smpt[4]=02ff65fd                                                                      
> [    1.665662] spi_nor_get_map_in_use:2882 smpt[5]=00000004                                                                      
> [    1.670965] spi_nor_get_map_in_use:2882 smpt[6]=ff0201fe                                                                      
> [    1.676267] spi_nor_get_map_in_use:2882 smpt[7]=00007ff1                                                                      
> [    1.681571] spi_nor_get_map_in_use:2882 smpt[8]=00037ff4                                                                      
> [    1.686874] spi_nor_get_map_in_use:2882 smpt[9]=03fbfff4                                                                      
> [    1.692176] spi_nor_get_map_in_use:2882 smpt[10]=ff0203fe                                                                     
> [    1.697566] spi_nor_get_map_in_use:2882 smpt[11]=03fbfff4                                                                     
> [    1.702954] spi_nor_get_map_in_use:2882 smpt[12]=00037ff4                                                                     
> [    1.708343] spi_nor_get_map_in_use:2882 smpt[13]=00007ff1                                                                     
> [    1.713732] spi_nor_get_map_in_use:2882 smpt[14]=ff0005ff                                                                     
> [    1.719120] spi_nor_get_map_in_use:2882 smpt[15]=03fffff4                                                                     
> [    1.724509] smpt[0]=[addr_width:00000000, read_dumy:08, read_opcode:00000065]                                                 
> [    1.731650] smpt[1]=[addr_width:00000000, read_dumy:08, read_opcode:00000000]                                                 
> [    1.738791] smpt[2]=[addr_width:00000000, read_dumy:08, read_opcode:00000065]   

You still don't print read_dummy correctly: %0x8 -> %08x.

Can you add

	if (!nor->addr_width)
		nor->addr_width = 3;

After the

	nor->addr_width = spi_nor_smpt_addr_width(nor, smpt[i]);

line.
                                              
> [    1.745932] spi_nor_get_map_in_use:2911 map_id=0 smpt_len:16 i=:3                                                             
> [    1.752018] End [addr_width:00000000, read_dumy:08, read_opcode:00000065]         
> 
> Also, one more thing when we are returning from the function, we are over-writing the values of addr_widthm read_dummy and read_opcode.
> Is this correct?

Yes, that's correct.

> 
> out:
>         nor->addr_width = addr_width;
>         nor->read_dummy = read_dummy;
>         nor->read_opcode = read_opcode;
>         return ret;
> }
>