linux-kernel - Re: [PATCH 1/1] rtc: ds1685: simplify getting .driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181022172815.GW17341@piout.net>
Date:   Mon, 22 Oct 2018 19:28:15 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        Joshua Kinard <kumba@...too.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-rtc@...r.kernel.org
Subject: Re: [PATCH 1/1] rtc: ds1685: simplify getting .driver_data

On 22/10/2018 17:53:35+0200, Alexandre Belloni wrote:
> On 21/10/2018 22:00:41+0200, Wolfram Sang wrote:
> > We should get 'driver_data' from 'struct device' directly. Going via
> > platform_device is an unneeded step back and forth.
> > 
> > Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> > ---
> > 
> > Build tested only. buildbot is happy.
> > 
> >  drivers/rtc/rtc-ds1685.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> Applied, thanks.
> 

By the way, is there any reason why this was not part of your patch back
in April? I had a deja vu feeling ;)


-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com