linux-kernel - Re: [PATCH v2] rtc: s35390a: Change buf's type to u8 in s35390a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181022173035.GX17341@piout.net>
Date:   Mon, 22 Oct 2018 19:30:35 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] rtc: s35390a: Change buf's type to u8 in s35390a_init

On 19/10/2018 13:43:45-0700, Nathan Chancellor wrote:
> Clang warns:
> 
> drivers/rtc/rtc-s35390a.c:124:27: warning: implicit conversion from
> 'int' to 'char' changes value from 192 to -64 [-Wconstant-conversion]
>         buf = S35390A_FLAG_RESET | S35390A_FLAG_24H;
>             ~ ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
> 1 warning generated.
> 
> Update buf to be an unsigned 8-bit integer, which matches the buf member
> in struct i2c_msg.
> 
> https://github.com/ClangBuiltLinux/linux/issues/145
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
> 
> v1 -> v2:
> 
> * Use u8 instead of unsigned char, as it's clearer that this is an
>   integer value and it's shorter.
> 
>  drivers/rtc/rtc-s35390a.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com