linux-kernel - Re: [PATCH v1 2/2] x86/hyperv: make HvNotifyLongSpinWait hypercall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Oct 2018 17:33:28 +0800
From:   Yi Sun <yi.y.sun@...ux.intel.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Waiman Long <longman@...hat.com>, Juergen Gross <jgross@...e.com>,
        linux-kernel@...r.kernel.org, x86@...nel.org, tglx@...utronix.de,
        chao.p.peng@...el.com, chao.gao@...el.com,
        isaku.yamahata@...el.com, michael.h.kelley@...rosoft.com,
        tianyu.lan@...rosoft.com, "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        Will Deacon <will.deacon@....com>
Subject: Re: [PATCH v1 2/2] x86/hyperv: make HvNotifyLongSpinWait hypercall

On 18-10-23 10:51:27, Peter Zijlstra wrote:
> On Tue, Oct 23, 2018 at 10:57:40AM +0800, Yi Sun wrote:
> > On 18-10-22 19:15:16, Peter Zijlstra wrote:
> 
> > > > >>>> +#if defined(CONFIG_X86_64) && defined(CONFIG_PARAVIRT_SPINLOCKS) && IS_ENABLED(CONFIG_HYPERV)
> > > > >>>> +			if (!hv_notify_long_spin_wait(SPIN_THRESHOLD - loop))
> > > > >>>> +				break;
> > > > >>>> +#endif
> > > 
> > > Secondly; how come you thought that was acceptable in any way shape or
> > > form?
> > > 
> > Sorry for that. Will try another way.
> 
> Can you try and explain why vcpu_is_preempted() doesn't work for you?

I thought HvSpinWaitInfo is used to notify hypervisor the spin number
which is different with vcpu_is_preempted. So I did not consider
vcpu_is_preempted.

But HvSpinWaitInfo is a quite simple function and could be combined
with vcpu_is_preempted together. So I think it is OK to use
vcpu_is_preempted to make codes clean. I will have a try.