linux-kernel - Re: [PATCH AUTOSEL 4.18 04/27] Input: i8042 - enable keyboard wakeups by default when s2idle is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181023154802.GA24189@sasha-vm>
Date:   Tue, 23 Oct 2018 11:48:02 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     stable@...r.kernel.org, linux-kernel@...r.kernel.org,
        Daniel Drake <drake@...lessm.com>
Subject: Re: [PATCH AUTOSEL 4.18 04/27] Input: i8042 - enable keyboard
 wakeups by default when s2idle is used

On Mon, Oct 22, 2018 at 09:58:21AM -0700, Dmitry Torokhov wrote:
>Hi Sasha,
>
>On Mon, Oct 22, 2018 at 06:19:01AM -0400, Sasha Levin wrote:
>> From: Daniel Drake <drake@...lessm.com>
>>
>> [ Upstream commit 684bec1092b6991ff2a7751e8a763898576eb5c2 ]
>>
>> Previously, on typical consumer laptops, pressing a key on the keyboard
>> when the system is in suspend would cause it to wake up (default or
>> unconditional behaviour). This happens because the EC generates a SCI
>> interrupt in this scenario.
>>
>> That is no longer true on modern laptops based on Intel WhiskeyLake,
>> including Acer Swift SF314-55G, Asus UX333FA, Asus UX433FN and Asus
>> UX533FD. We confirmed with Asus EC engineers that the "Modern Standby"
>> design has been modified so that the EC no longer generates a SCI
>> in this case; the keyboard controller itself should be used for wakeup.
>>
>> In order to retain the standard behaviour of being able to use the
>> keyboard to wake up the system, enable serio wakeups by default on
>> platforms that are using s2idle.
>
>I disagree that this should be included in stable as it does not fix a
>regression on the aforementioned platforms and has a potential to alter
>the behavior. The fact that the system does not wake up on keyboard is
>not a showstopper, wakeup usually happens on lid open anyway.
>
>It is hitting 4.19 LTS train and that should be enough. Please do not
>pick up for earlier stables.

Dropped, thanks!