linux-kernel - Re: [PATCH AUTOSEL 4.18 08/27] Input: evdev - add a schedule point in evdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181023154908.GB24189@sasha-vm>
Date:   Tue, 23 Oct 2018 11:49:08 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     stable@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.18 08/27] Input: evdev - add a schedule point
 in evdev_write()

On Mon, Oct 22, 2018 at 10:02:44AM -0700, Dmitry Torokhov wrote:
>Hi Sasha,
>
>On Mon, Oct 22, 2018 at 06:19:05AM -0400, Sasha Levin wrote:
>> From: Dmitry Torokhov <dmitry.torokhov@...il.com>
>>
>> [ Upstream commit 36d2582ff235b4e01ad64a734c877a52dc762d9c ]
>>
>> Large writes to evdev interface may cause rcu stalls. Let's add
>> cond_resched() to the loop to avoid this.
>
>This is not needed in stable:
>
>- the interfaces are not accessible for unprivileged users so there is
>  no DOS concerns
>- the issue can only happen on non-preemptible kernels
>- the issue only showed up with synthetic test and not real life use
>  cases
>- this is not a regression
>
>The same goes to similar patches to mousedev, joydev and uinput that you
>autoselected.

Dropped, thanks!

--
Thanks,
Sasha