linux-kernel - Re: [PATCH v2 1/5] x86/vdso: Renames variable to fix shadow warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <93692F0D-D25B-4225-B127-4988E43B4CE1@amacapital.net>
Date:   Mon, 22 Oct 2018 19:13:53 -0700
From:   Andy Lutomirski <luto@...capital.net>
To:     Leonardo Brás <leobras.c@...il.com>
Cc:     lkcamp@...ts.libreplanetbr.org, Borislav Petkov <bp@...en8.de>,
        David.Laight@...lab.com, Andy Lutomirski <luto@...nel.org>,
        Ingo Molnar <mingo@...nel.org>, helen@...keco.de,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/5] x86/vdso: Renames variable to fix shadow warning.



> On Oct 22, 2018, at 6:10 PM, Leonardo Brás <leobras.c@...il.com> wrote:
> 
> Renames the char variable to avoid shadowing a variable previously
> declared on this function.

How about “The go32() and go64() functions has an argument and a local variable called ‘name’.  Rename both to clarify the code and to fix a warning with -Wshadow.”

Other than that, Acked-by: Andy Lutomirski <luto@...nel.org>

Ingo or Thomas, it probably makes sense to just apply this to tip:x86/vdso, since it’s an improvement regardless of the fate of the rest of the series.