linux-kernel - Re: [PATCH v2 1/5] x86/vdso: Renames variable to fix shadow warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADvQ+rEk-VE4uLZ_iRi26BnuEWFzCNZxdcdHRgWW6YbKS4R_tA@mail.gmail.com>
Date:   Tue, 23 Oct 2018 21:39:33 -0300
From:   Leonardo Bras <leobras.c@...il.com>
To:     luto@...capital.net
Cc:     lkcamp@...ts.libreplanetbr.org, Borislav Petkov <bp@...en8.de>,
        David.Laight@...lab.com, Andy Lutomirski <luto@...nel.org>,
        Ingo Molnar <mingo@...nel.org>, helen@...keco.de,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        linux-kbuild@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/5] x86/vdso: Renames variable to fix shadow warning.

Hello Andy,

Yeah, it's much better. I will replace this part of the commit message.
It will be fixed for v3.

Thank you!


On Mon, Oct 22, 2018 at 11:13 PM Andy Lutomirski <luto@...capital.net> wrote:

> How about “The go32() and go64() functions has an argument and a local variable called ‘name’.  Rename both to clarify the code and to fix a warning with -Wshadow.”
>
> Other than that, Acked-by: Andy Lutomirski <luto@...nel.org