linux-kernel - Re: [PATCH v2] rtlwifi: remove set but not used variable 'radiob_array_table' and 'radiob

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19b16ca89b5cde607338513638d4ef8e3a3d2802.camel@perches.com>
Date:   Tue, 23 Oct 2018 12:33:23 -0700
From:   Joe Perches <joe@...ches.com>
To:     zhong jiang <zhongjiang@...wei.com>, kvalo@...eaurora.org
Cc:     davem@...emloft.net, pkshih@...ltek.com,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] rtlwifi: remove set but not used variable
 'radiob_array_table' and 'radiob_arraylen'

On Tue, 2018-10-23 at 16:28 +0800, zhong jiang wrote:
> radiob_array_table' and 'radiob_arraylen' are not used after setting its value.
> It is safe to remove the unused variable. Meanwhile, radio B radio should be
> removed as well. because it will no longer be referenced.

The patch subject is a bit off and too generic here.

This is specific to rtl8723ae and not rtlwifi so it is
probably better for the subject to be something like:

[PATCH] rtl8723ae: Remove set but not used variables and #defines

> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c   | 5 +----
>  drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c | 4 ----
>  drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h | 2 --