lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Oct 2018 00:52:44 +0000 From: Pkshih <pkshih@...ltek.com> To: "joe@...ches.com" <joe@...ches.com>, "zhongjiang@...wei.com" <zhongjiang@...wei.com>, "kvalo@...eaurora.org" <kvalo@...eaurora.org> CC: "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2] rtlwifi: remove set but not used variable 'radiob_array_table' and 'radiob_arraylen' On Tue, 2018-10-23 at 12:33 -0700, Joe Perches wrote: > On Tue, 2018-10-23 at 16:28 +0800, zhong jiang wrote: > > radiob_array_table' and 'radiob_arraylen' are not used after setting its > value. > > It is safe to remove the unused variable. Meanwhile, radio B radio should be > > removed as well. because it will no longer be referenced. > > The patch subject is a bit off and too generic here. > > This is specific to rtl8723ae and not rtlwifi so it is > probably better for the subject to be something like: > > [PATCH] rtl8723ae: Remove set but not used variables and #defines I'd like 'rtlwifi: rtl8723ae: ' as subject prefix. > > > Signed-off-by: zhong jiang <zhongjiang@...wei.com> > > --- > > drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 5 +---- > > drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.c | 4 ---- > > drivers/net/wireless/realtek/rtlwifi/rtl8723ae/table.h | 2 -- > > > ------Please consider the environment before printing this e-mail.
Powered by blists - more mailing lists