lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Oct 2018 01:47:57 -0700 From: Stephen Boyd <sboyd@...nel.org> To: Jerome Brunet <jbrunet@...libre.com>, Jianxin Pan <jianxin.pan@...ogic.com>, Neil Armstrong <narmstrong@...libre.com> Cc: Yixun Lan <yixun.lan@...ogic.com>, Kevin Hilman <khilman@...libre.com>, Carlo Caione <carlo@...one.org>, Michael Turquette <mturquette@...libre.com>, Rob Herring <robh@...nel.org>, Miquel Raynal <miquel.raynal@...tlin.com>, Boris Brezillon <boris.brezillon@...tlin.com>, Martin Blumenstingl <martin.blumenstingl@...glemail.com>, Liang Yang <liang.yang@...ogic.com>, Jian Hu <jian.hu@...ogic.com>, Qiufang Dai <qiufang.dai@...ogic.com>, Hanjie Lin <hanjie.lin@...ogic.com>, Victor Wan <victor.wan@...ogic.com>, linux-clk@...r.kernel.org, linux-amlogic@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver Quoting Jianxin Pan (2018-10-23 23:29:24) > On 2018/10/19 1:13, Stephen Boyd wrote: > > Quoting Jianxin Pan (2018-10-17 22:07:25) > [...] > >> diff --git a/drivers/clk/meson/mmc-clkc.c b/drivers/clk/meson/mmc-clkc.c > >> new file mode 100644 > >> index 0000000..5555e3f > >> --- /dev/null > >> +++ b/drivers/clk/meson/mmc-clkc.c > >> @@ -0,0 +1,296 @@ > >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > >> +/* > >> + * Amlogic Meson MMC Sub Clock Controller Driver > >> + * > >> + * Copyright (c) 2017 Baylibre SAS. > >> + * Author: Jerome Brunet <jbrunet@...libre.com> > >> + * > >> + * Copyright (c) 2018 Amlogic, inc. > >> + * Author: Yixun Lan <yixun.lan@...ogic.com> > >> + */ > >> + > >> +#include <linux/clk.h> > > > > clk-provider.h instead of clk.h?> > Maybe we need to keep clk.h > devm_clk_get() is called in mmc_clkc_register_mux() to get parent in from DTS. > I'm sorry to miss this in previous reply. OK. But also include clk-provider.h if provider APIs are being used here.
Powered by blists - more mailing lists