linux-kernel - Re: [PATCH V2 3/4] misc/pvpanic: add support to pvpanic device information by using FDT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Oct 2018 16:12:47 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     peng.hao2@....com.cn
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andy Shevchenko <andy@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        hutao@...fujitsu.com
Subject: Re: [PATCH V2 3/4] misc/pvpanic: add support to pvpanic device
 information by using FDT

On Wed, Oct 24, 2018 at 12:02 PM Peng Hao <peng.hao2@....com.cn> wrote:
>
> By default, when ACPI tables and FDT coexist for ARM64,
> current kernel takes precedence over FDT to get device information.
> This patch increases the way to get information through FDT.

>   *  pvpanic.c - pvpanic Device Support
>   *
>   *  Copyright (C) 2013 Fujitsu.
> + *  Copyright (C) 2018 ZTE.
>   *
>   *  This program is free software; you can redistribute it and/or modify
>   *  it under the terms of the GNU General Public License as published by

This hunk would be a separate patch which includes switch to SPDX and
removing the file name from the file itself.

> @@ -25,6 +26,10 @@
>  #include <linux/init.h>
>  #include <linux/types.h>
>  #include <linux/acpi.h>
> +#include <linux/of.h>
> +#include <linux/of_address.h>

> +#include <asm/virt.h>

asm/* goes after linux/*

> +#include <linux/platform_device.h>

Better to keep sorted.

> +       if (!mem)
> +               return -EINVAL;
> +
> +       if (!devm_request_mem_region(&pdev->dev, mem->start,
> +                                    resource_size(mem), pdev->name))
> +               return -EBUSY;
> +
> +       base = devm_ioremap(&pdev->dev, mem->start,
> +                           resource_size(mem));
> +       if (base == NULL)
> +               return -EFAULT;

devm_ioremap_resource()

> +static const struct of_device_id pvpanic_mmio_match[] = {
> +       { .compatible = "qemu,pvpanic-mmio", },
> +       {},

terminators better w/o comma.

> +};

-- 
With Best Regards,
Andy Shevchenko