linux-kernel - Re: [PATCH V2 4/4] misc/pvpanic : pvpanic: add document for pvpanic-mmio DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+Bj2A8z=_vTr+sz4HGCSC8zN7VQkWL1inJYQ56JSkPNg@mail.gmail.com>
Date:   Wed, 24 Oct 2018 08:35:31 -0500
From:   Rob Herring <robh+dt@...nel.org>
To:     peng.hao2@....com.cn
Cc:     Mark Rutland <mark.rutland@....com>, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andy Shevchenko <andy@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        platform-driver-x86@...r.kernel.org, hutao@...fujitsu.com
Subject: Re: [PATCH V2 4/4] misc/pvpanic : pvpanic: add document for
 pvpanic-mmio DT

Please Cc DT list for bindings.

On Wed, Oct 24, 2018 at 4:01 AM Peng Hao <peng.hao2@....com.cn> wrote:
>

Commit message?

"dt-bindings: misc: ..." for the subject.

> Signed-off-by: Peng Hao <peng.hao2@....com.cn>
> ---
>  .../devicetree/bindings/arm/pvpanic-mmio.txt       | 29 ++++++++++++++++++++++

As Mark said, not ARM specific. So please move to bindings/misc/ and
use the compatible string for the name (qemu,pvpanic-mmio.txt).

>  1 file changed, 29 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/pvpanic-mmio.txt
>
> diff --git a/Documentation/devicetree/bindings/arm/pvpanic-mmio.txt b/Documentation/devicetree/bindings/arm/pvpanic-mmio.txt
> new file mode 100644
> index 0000000..a6bdacd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/pvpanic-mmio.txt
> @@ -0,0 +1,29 @@
> +* QEMU PVPANIC MMIO Configuration bindings for ARM

Drop the "for ARM"

> +
> +QEMU's emulation / virtualization targets provide the following PVPANIC
> +MMIO Configuration interface on the "virt" machine.
> +type:
> +
> +- a read-write, 16-bit wide data register.
> +
> +QEMU exposes the data register to guests as memory mapped registers.

I have to wonder why we need a QEMU specific way to signal a panic.
What about every real platform that panics? What are they supposed to
do? Shouldn't this be a PSCI call so we can have something not per
platform?

> +
> +Required properties:
> +
> +- compatible: "qemu,pvpanic-mmio".
> +- reg: the MMIO region used by the device.
> +  * Bytes 0x0  Write panic event to the reg when guest OS panics.
> +  * Bytes 0x1  Reserved.
> +
> +Example:
> +
> +/ {
> +        #size-cells = <0x2>;
> +        #address-cells = <0x2>;
> +
> +        pvpanic-mmio@...0000 {
> +                compatible = "qemu,pvpanic-mmio";
> +                reg = <0x0 0x9060000 0x0 0x2>;
> +        };
> +};
> +
> --
> 1.8.3.1
>