linux-kernel - Re: [PATCH 05/10] sched/fair: Hoist idle_stamp up from idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3cec1fb2-d2f8-9693-178e-ac1b9aa77506@oracle.com>
Date:   Thu, 25 Oct 2018 10:04:52 -0400
From:   Steven Sistare <steven.sistare@...cle.com>
To:     Valentin Schneider <valentin.schneider@....com>, mingo@...hat.com,
        peterz@...radead.org
Cc:     subhra.mazumdar@...cle.com, dhaval.giani@...cle.com,
        rohit.k.jain@...cle.com, daniel.m.jordan@...cle.com,
        pavel.tatashin@...rosoft.com, matt@...eblueprint.co.uk,
        umgwanakikbuti@...il.com, riel@...hat.com, jbacik@...com,
        juri.lelli@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/10] sched/fair: Hoist idle_stamp up from idle_balance

On 10/25/2018 9:47 AM, Valentin Schneider wrote:
> Hi Steve,
> 
> On 22/10/2018 15:59, Steve Sistare wrote:
> [...]
>> @@ -6740,8 +6744,19 @@ static void check_preempt_wakeup(struct rq *rq, struct task_struct *p, int wake_
>>  	return p;
>>  
>>  idle:
>> +	/*
>> +	 * We must set idle_stamp _before_ calling idle_balance(), such that we
>> +	 * measure the duration of idle_balance() as idle time.
>> +	 */
>> +	IF_SMP(rq->idle_stamp = rq_clock(rq);)
>> +
>>  	new_tasks = idle_balance(rq, rf);
>>  
>> +	if (new_tasks)
>> +		IF_SMP(rq->idle_stamp = 0;)
>> +
>> +	schedstat_end_time(rq->find_time, time);
> 	^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> That's a stray hunk from 10/10

Thanks Valentin, will fix in next version.  I reordered the patches and missed this.

- Steve