linux-kernel - Re: Regression: OOPs on boot due to "wlcore: Add support for optional wakeirq"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181025172601.GA31348@atomide.com>
Date:   Thu, 25 Oct 2018 10:26:01 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     John Stultz <john.stultz@...aro.org>
Cc:     Kalle Valo <kvalo@...eaurora.org>, Eyal Reizer <eyalr@...com>,
        lkml <linux-kernel@...r.kernel.org>,
        Anders Roxell <anders.roxell@...aro.org>
Subject: Re: Regression: OOPs on boot due to "wlcore: Add support for
 optional wakeirq"

* John Stultz <john.stultz@...aro.org> [181025 17:04]:
> Hey Tony,
>   In testing linus/master on my hikey board, I'm hitting the following
> OOPS on bootup:
> 
> [    1.870279] Unable to handle kernel read from unreadable memory at
...
> [    1.870485]  wl1271_probe+0x210/0x350
> [    1.870491]  sdio_bus_probe+0x100/0x128
...
> I've bisected it down to 3c83dd577c7f ("wlcore: Add support for
> optional wakeirq").
> 
> It seems since we don't have a wakeirq value in the dts, the wakeirq
> value in wl1271_probe() is zero, which then causes trouble in
> irqd_get_trigger_type(irq_get_irq_data(wakeirq)).
> 
> Should we check wakeirq before we set the second elements of res[]?

Oh sorry about that, yeah I'll take a look and post a patch ASAP.
Hmm for me value 0 there causes no errors looks like.

Regards,

Tony