linux-kernel - Re: [PATCH AUTOSEL 3.18 15/98] usb: musb: Fix a few off-by-one lengths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1acd4b7f-d13c-5ad6-3e9f-c58bcd0469f3@rasmusvillemoes.dk>
Date:   Fri, 26 Oct 2018 12:47:13 +0200
From:   Rasmus Villemoes <linux@...musvillemoes.dk>
To:     Sasha Levin <sashal@...nel.org>, stable@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Felipe Balbi <balbi@...com>
Subject: Re: [PATCH AUTOSEL 3.18 15/98] usb: musb: Fix a few off-by-one
 lengths

On 2018-10-25 16:17, Sasha Levin wrote:
> From: Rasmus Villemoes <linux@...musvillemoes.dk>
> 
> [ Upstream commit e87c3f80ad0490d26ffe04754b7d094463b40f30 ]
> 
> !strncmp(buf, "force host", 9) is true if and only if buf starts with
> "force hos". This was obviously not what was intended. The same error
> exists for "force full-speed", "force high-speed" and "test
> packet". Using strstarts avoids the error-prone hardcoding of the
> prefix length.

Not sure this qualifies for -stable, but if some other "real" -stable
patch depends textually on this, it should be ok/harmless. Just my 2c.

Rasmus