linux-kernel - Re: [PATCH AUTOSEL 3.18 36/98] usb: serial: handle -ENODEV quietly in generic_submit_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181026105423.GB2015@sasha-vm>
Date:   Fri, 26 Oct 2018 06:54:23 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     stable@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jeremiah Mahler <jmmahler@...il.com>
Subject: Re: [PATCH AUTOSEL 3.18 36/98] usb: serial: handle -ENODEV quietly
 in generic_submit_read_urb

On Fri, Oct 26, 2018 at 10:39:29AM +0200, Johan Hovold wrote:
>Hi Sasha,
>
>On Thu, Oct 25, 2018 at 10:17:51AM -0400, Sasha Levin wrote:
>> From: Jeremiah Mahler <jmmahler@...il.com>
>>
>> [ Upstream commit 04f9c6e6d17584340fb6c8a9469a0e6df28876d2 ]
>>
>> If a USB serial device (e.g. /dev/ttyUSB0) with an active program is
>> unplugged, an -ENODEV (19) error will be produced after it gives up
>> trying to resubmit a read.
>>
>>   usb_serial_generic_submit_read_urb - usb_submit_urb failed: -19
>>
>> Add -ENODEV as one of the permanent errors along with -EPERM that
>> usb_serial_generic_submit_read_urb() handles quietly without an error.
>>
>> Signed-off-by: Jeremiah Mahler <jmmahler@...il.com>
>> Signed-off-by: Johan Hovold <johan@...nel.org>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>
>This isn't a bug fix, but more of a clean up patch and hence does not
>qualify for stable. So specifically the stable tag was left out on
>purpose.
>
>I never got a chance to talk to you in Edinburgh, but Greg mentioned you
>had an opt-out list for your autosel work which I'd like to be added to.
>
>I always mark bug fixes that qualify for stable as such so anything else
>that your process picks up would already have been considered and
>rejected by me.

I'll drop it, thanks Johan!

--
Thanks,
Sasha