lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 26 Oct 2018 08:41:23 -0600 From: Jens Axboe <axboe@...nel.dk> To: Kyungtae Kim <kt0755@...il.com> Cc: jikos@...nel.org, Byoungyoung Lee <lifeasageek@...il.com>, DaeRyong Jeong <threeearcat@...il.com>, linux-block@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] floppy: Avoid memory access beyond the array bounds in setup_rw_floppy() On 10/26/18 8:39 AM, Kyungtae Kim wrote: > diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c > index a8cfa01..41160a1 100644 > --- a/drivers/block/floppy.c > +++ b/drivers/block/floppy.c > @@ -3146,6 +3146,9 @@ static int raw_cmd_copyin(int cmd, void __user *param, > */ > return -EINVAL; > > + if (ptr->cmd_count > ARRAY_SIZE(ptr->cmd)) > + return -EINVAL; > + > for (i = 0; i < 16; i++) > ptr->reply[i] = 0; > ptr->resultcode = 0; Almost there, the tabs have been turned into spaces. This could be a mailer issue, what are you using to send out the patch? -- Jens Axboe
Powered by blists - more mailing lists