linux-kernel - Re: [PATCH] zynq-fpga: Only route PR via PCAP when required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJYdmePrXcH=kYJFAD=dMWem0r6CpP_+P0NB6qGE-8TLT9rcRQ@mail.gmail.com>
Date:   Fri, 26 Oct 2018 10:04:21 -0700
From:   Moritz Fischer <moritz.fischer.private@...il.com>
To:     Michal Simek <michal.simek@...inx.com>
Cc:     mike.looijmans@...ic.nl, linux-fpga@...r.kernel.org,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Alan Tull <atull@...nel.org>
Subject: Re: [PATCH] zynq-fpga: Only route PR via PCAP when required

Hi Michal,

On Fri, Oct 26, 2018 at 12:54 AM Michal Simek <michal.simek@...inx.com> wrote:

> > Ok, I had suspected you tested it and probably didn't run into issues,
> > but just wanted to make sure we think about it. If you don't mind, swap
> > it around as I suggested just to be safe.
> >
> > With that change feel free to add my Reviewed-by: Moritz Fischer
> > <mdf@...nel.org> in your v2.
>
> That clock can be used by something else that's why you didn't observe
> any issue. Anyway I have no problem with reverting that setting back
> that icap can be used.

Ok, thanks for clarification, that was what I assumed :)

> In general there should be synchronization mechanism for this. And also
> driver "feature" not to enable access from icap for security reason. But
> that's something what should be done in other patch.

Yeah I'll have to look at remote notifications for FPGA managers
soon-ish for another
project as discussed at ELCE. Part of that would be synchronization I guess :)

Umhh, based on the secure state read from CTRL_SEC_EN bit, or did you
think along the
lines of "xlnx,no-icap" property that your bootloader / dt would provide?

Cheers,

Moritz