linux-kernel - Re: [PATCH v2] zynq-fpga: Only route PR via PCAP when required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 1 Nov 2018 13:33:39 -0500
From:   Alan Tull <atull@...nel.org>
To:     mike.looijmans@...ic.nl
Cc:     linux-fpga@...r.kernel.org,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Michal Simek <michal.simek@...inx.com>,
        Moritz Fischer <mdf@...nel.org>, git@...inx.com
Subject: Re: [PATCH v2] zynq-fpga: Only route PR via PCAP when required

On Wed, Oct 24, 2018 at 2:53 AM Mike Looijmans <mike.looijmans@...ic.nl> wrote:

Hi Mike,

>
> The Xilinx Zynq FPGA driver takes ownership of the PR interface, making
> it impossible to use the ICAP interface for partial reconfiguration.
>
> This patch changes the driver to only activate PR over PCAP while the
> device is actively being accessed by the driver for programming.
>
> This allows both PCAP and ICAP interfaces to be used for PR.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@...ic.nl>
> Reviewed-by: Moritz Fischer <mdf@...nel.org>
Acked-by: Alan Tull <atull@...nel.org>

Thanks for submitting!

Alan

> ---
> v2: Move the register setting in between the clock enable/disable
>
>  drivers/fpga/zynq-fpga.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
> index 3110e00..ff3a427 100644
> --- a/drivers/fpga/zynq-fpga.c
> +++ b/drivers/fpga/zynq-fpga.c
> @@ -501,6 +501,10 @@ static int zynq_fpga_ops_write_complete(struct fpga_manager *mgr,
>         if (err)
>                 return err;
>
> +       /* Release 'PR' control back to the ICAP */
> +       zynq_fpga_write(priv, CTRL_OFFSET,
> +               zynq_fpga_read(priv, CTRL_OFFSET) & ~CTRL_PCAP_PR_MASK);
> +
>         err = zynq_fpga_poll_timeout(priv, INT_STS_OFFSET, intr_status,
>                                      intr_status & IXR_PCFG_DONE_MASK,
>                                      INIT_POLL_DELAY,
> --
> 1.9.1
>