linux-kernel - Re: Bug: swap discard issue with zram caused by "block: don't deal with discard limit in blkdev_issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALjTZvZtmTCvLQph95rNQk73L23h=1QaODny_ZOf9F1MjcsMFQ@mail.gmail.com>
Date:   Sun, 28 Oct 2018 08:53:03 +0000
From:   Rui Salvaterra <rsalvaterra@...il.com>
To:     ming.lei@...hat.com
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: Bug: swap discard issue with zram caused by "block: don't deal
 with discard limit in blkdev_issue_discard()"

On Sun, 28 Oct 2018 at 01:02, Ming Lei <ming.lei@...hat.com> wrote:
>
> On Fri, Oct 26, 2018 at 08:50:20AM +0100, Rui Salvaterra wrote:
> > On Fri, 26 Oct 2018 at 07:27, Ming Lei <ming.lei@...hat.com> wrote:
> > >
> > > The patch titled with 'block: make sure discard bio is aligned with logical block size'
> > > in the list may fix this issue, please test and see if it works.
> > >
> > > Thanks,
> > > Ming
> >
> > Hi, Ming,
> >
> > Thanks for the quick reply. Unfortunately, it doesn't seem to apply
> > cleanly to 4.19. To which tree/tag/commit should I apply the series?
>
> The whole patchset is against linus tree (44786880df196a4200).
>
> I am sure that the 1st patch can be applied cleanly against v4.19, and
> it is enough for fixing this issue, please double check.
>
> [ming@...g linux]$ git log --oneline -1
> 84df9525b0c2 Linux 4.19
> [ming@...g linux]$ git am ~/emails/blk/181026\ \[PATCH\ 1∕3\]\ block\:\ make\ sure\ discard\ bio\ is\ aligned\ with\ logical\ block\ size.eml
> Applying: block: make sure discard bio is aligned with logical block size
> [ming@...g linux]$
>
>
> Thanks,
> Ming

Hi, Ming,

You're, right, of course. I had reverted the aforementioned commit, so
the patch set obviously wouldn't apply anymore. After checking out
v4.19 again, everything went smoothly. I confirm the patch set fixes
the issue for me, which means this series is

Tested-by: Rui Salvaterra <rsalvaterra@...il.com>

Thanks again,

Rui