linux-kernel - Re: [PATCH 02/14] blk-mq: abstract out queue map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1540838039.196084.78.camel@acm.org>
Date:   Mon, 29 Oct 2018 11:33:59 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/14] blk-mq: abstract out queue map

On Mon, 2018-10-29 at 10:37 -0600, Jens Axboe wrote:
> struct blk_mq_tag_set {
> -	unsigned int		*mq_map;
> +	struct blk_mq_queue_map	map[HCTX_MAX_TYPES];
>  	const struct blk_mq_ops	*ops;
>  	unsigned int		nr_hw_queues;
>  	unsigned int		queue_depth;	/* max hw supported */

How about documenting that nr_hw_queues is the number of hardware queues across
all hardware queue types instead of e.g. the number of hardware queues for a
single hardware queue type? This is something that only became clear to me after
having reviewed a later patch in this series. Anyway:

Reviewed-by: Bart Van Assche <bvanassche@....org>