[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181030133239.GB41022@google.com>
Date: Tue, 30 Oct 2018 08:32:39 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Suganath Prabu <suganath-prabu.subramani@...adcom.com>
Cc: lukas@...ner.de, linux-scsi@...r.kernel.org,
linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
benh@...nel.crashing.org, ruscur@...sell.cc,
sbobroff@...ux.ibm.com, oohall@...il.com,
andy.shevchenko@...il.com, Sathya.Prakash@...adcom.com,
sreekanth.reddy@...adcom.com
Subject: Re: [v6 2/4] mpt3sas: Fix Sync cache command failure during driver
unload
On Tue, Oct 23, 2018 at 03:51:19PM +0530, Suganath Prabu wrote:
> This is to fix Sync cache and start stop command
> failures with DID_NO_CONNECT during driver unload.
>
> 1) Release drives first from SML, then remove internally
> in driver.
> 2) And allow sync cache and Start stop commands to firmware,
> even when remove_host flag is set
This looks like it should be two or maybe even three patches: (1) call
sas_remove_host() before releasing volumes and ports, (2) skipping
sas_port_delete_phy() and sas_port_delete() when ioc->remove_host (I'm not
sure if this is logically part of the sas_remove_host() change), and (3)
add _scsih_allow_scmd_to_device() -- this is purely mpt3sas-specific thing
independent of the SCSI midlayer.
Bjorn
Powered by blists - more mailing lists